security-tools/sigma-rules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FR] Add additional verification to BBR unit tests (#2909)

Browse Source 
* Fixes bug in unit tests

* fix linting
This commit is contained in:
eric-forte-elastic
2023-07-06 13:06:36 +00:00
committed by GitHub
parent d8969f8df1
commit 9e5f69dc5b
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_all_rules.py
+10 -1
View File
@@ -485,14 +485,23 @@ class TestRuleFiles(BaseRuleTest):
def test_bbr_in_correct_dir(self):
"""Ensure that BBR are in the correct directory."""
for rule in self.bbr:
# Is the rule a BBR
self.assertEqual(rule.contents.data.building_block_type, 'default',
f'{self.rule_str(rule)} should have building_block_type = "default"')
# Is the rule in the rules_building_block directory
self.assertEqual(rule.path.parent.name, 'rules_building_block',
f'{self.rule_str(rule)} should be in the rules_building_block directory')
def test_non_bbr_in_correct_dir(self):
"""Ensure that non-BBR are not in BBR directory."""
proper_directory = 'rules_building_block'
for rule in self.all_rules:
if rule.path.parent.name == 'rules_building_block':
self.assertIn(rule, self.bbr, f'{self.rule_str(rule)} should be in the rules_building_block directory')
self.assertIn(rule, self.bbr, f'{self.rule_str(rule)} should be in the {proper_directory}')
# Is the rule of type BBR
self.assertEqual(rule.contents.data.building_block_type, None,
f'{self.rule_str(rule)} should not have building_block_type or be in {proper_directory}')
class TestRuleMetadata(BaseRuleTest):