Merge pull request #3756 from nasbench/enahance-duplicate-id-test

feat: change duplicate test to check lower case
2022-12-05 14:45:19 +01:00
parent 122cb47d71 e343d016e9
commit ba601ff4ba
1 changed files with 2 additions and 2 deletions
@@ -336,12 +336,12 @@ class TestRules(unittest.TestCase):
                print(
                    Fore.YELLOW + "Rule {} has a malformed 'id' (not 36 chars).".format(file))
                faulty_rules.append(file)
-            elif id in dict_id.keys():
+            elif id.lower() in dict_id.keys():
                print(
                    Fore.YELLOW + "Rule {} has the same 'id' than {} must be unique.".format(file, dict_id[id]))
                faulty_rules.append(file)
            else:
-                dict_id[id] = file
+                dict_id[id.lower()] = file

        self.assertEqual(faulty_rules, [], Fore.RED +
                         "There are rules with missing or malformed 'id' fields. Create an id (e.g. here: https://www.uuidgenerator.net/version4) and add it to the reported rule(s).")