So in the previous refactor, we made the dedicated method to parse usernames and passwords from the split up config values. However, that didn't work, because on a single iteration of the loop, you only have access to a possible username OR password. The other matching key will be another iteration of the loop. Because of this, no credential pairs were being reported. The only way I can see around this (maybe because I'm a ruby newb) would be to iterate over configs, and if the user or password regex matches, add the matching value to a hash, which is identified by a key for both user & pass. Then upon completion of the loop, it'd iterate over the hash, finding keys that had both user & pass values.
Metasploit

The Metasploit Framework is released under a BSD-style license. See COPYING for more details.
The latest version of this software is available from http://metasploit.com/
Bug tracking and development information can be found at: https://dev.metasploit.com/redmine/projects/framework/
The public GitHub source repository can be found at: https://github.com/rapid7/metasploit-framework
Questions and suggestions can be sent to: msfdev(at)metasploit.com
The framework mailing list is the place to discuss features and ask for help. To subscribe, visit the following web page: https://mail.metasploit.com/mailman/listinfo/framework
The mailing list archives are available from: https://mail.metasploit.com/pipermail/framework/
Installing
Generally, you should use the installer which contains all dependencies and will get you up and running with a few clicks. See the Dev Environment Setup if you'd like to deal with dependencies on your own.
Using Metasploit
Metasploit can do all sorts of things. The first thing you'll want to do
is start msfconsole, but after that, you'll probably be best served by
reading some of the great tutorials online:
Contributing
See the Dev Environment Setup guide on GitHub which will walk you through the whole process starting from installing all the dependencies, to cloning the repository, and finally to submitting a pull request. For slightly more info, see Contributing.