adam/metasploit-gs
1
0
Fork 0
Code Issues Pull Requests Actions 9 Packages Projects Releases Wiki Activity

Only open /dev/null if we need it

Browse Source
This commit is contained in:
James Lee
2012-05-13 17:48:50 -06:00
parent f988622369
commit e6719f18ab
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
external/source/meterpreter/source/extensions/stdapi/server/sys/process/process.c
Vendored
+8 -9
View File
@@ -673,15 +673,6 @@ DWORD request_sys_process_execute(Remote *remote, Packet *packet)
// Add the channel identifier to the response packet
packet_add_tlv_uint(response, TLV_TYPE_CHANNEL_ID,channel_get_id(newChannel));
} else {
// need to /dev/null it all
if( (devnull = open("/dev/null", O_RDONLY) ) == -1) {
// XXX This is possible, due to chroots etc. We could close
// fd 0/1/2 and hope the program isn't buggy.
result = GetLastError();
break;
}
}
/*
@@ -711,6 +702,14 @@ DWORD request_sys_process_execute(Remote *remote, Packet *packet)
dup2(out[1], 2);
}
} else {
// need to /dev/null it all
if( (devnull = open("/dev/null", O_RDONLY) ) == -1) {
// XXX This is possible, due to chroots etc. We could close
// fd 0/1/2 and hope the program isn't buggy.
result = GetLastError();
break;
}
dup2(devnull, 0);
dup2(devnull, 1);
dup2(devnull, 2);