Files
sigma-rules/detection_rules/version_lock.py
T
Justin Ibarra 7710e2b798 Add DeprecatedCollection to RuleCollection to bypass validation (#1454)
* Add DeprecatedCollection to RuleCollection to bypass validation
* use DeprecatedRule properties in RuleCollection
* use RuleCollection filter for max/min filtering in Package
2021-09-01 15:29:53 -08:00

167 lines
7.2 KiB
Python

# Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
# or more contributor license agreements. Licensed under the Elastic License
# 2.0; you may not use this file except in compliance with the Elastic License
# 2.0.
"""Helper utilities to manage the version lock."""
from copy import deepcopy
from typing import List, Optional
import click
from .rule_loader import RuleCollection
from .semver import Version
from .utils import dict_hash, load_etc_dump, save_etc_dump, cached
ETC_VERSION_LOCK_FILE = "version.lock.json"
ETC_DEPRECATED_RULES_FILE = "deprecated_rules.json"
MIN_LOCK_VERSION_DEFAULT = Version("7.13.0")
def _convert_lock_version(stack_version: Optional[str]) -> Version:
"""Convert an optional stack version to the minimum for the lock."""
if stack_version is None:
return MIN_LOCK_VERSION_DEFAULT
return max(Version(stack_version), MIN_LOCK_VERSION_DEFAULT)
def get_locked_version(rule_id: str, min_stack_version: Optional[str] = None) -> Optional[int]:
rules_versions = load_versions()
if rule_id in rules_versions:
latest_version_info = rules_versions[rule_id]
stack_version_info = latest_version_info.get("previous", {}).get(min_stack_version, latest_version_info)
return stack_version_info['version']
def get_locked_hash(rule_id: str, min_stack_version: Optional[str] = None) -> Optional[str]:
rules_versions = load_versions()
# Get the version info matching the min_stack_version if present
if rule_id in rules_versions:
latest_version_info = rules_versions[rule_id]
stack_version_info = latest_version_info.get("previous", {}).get(min_stack_version, latest_version_info)
existing_sha256: str = stack_version_info['sha256']
return existing_sha256
def manage_versions(rules: RuleCollection,
exclude_version_update=False, save_changes=False,
verbose=True) -> (List[str], List[str], List[str]):
"""Update the contents of the version.lock file and optionally save changes."""
from .packaging import current_stack_version
current_versions = deepcopy(load_versions())
versions_hash = dict_hash(current_versions)
rule_deprecations = load_etc_dump(ETC_DEPRECATED_RULES_FILE)
verbose_echo = click.echo if verbose else (lambda x: None)
already_deprecated = set(rule_deprecations)
deprecated_rules = set(rules.deprecated.id_map)
new_rules = set(rule.id for rule in rules if rule.contents.latest_version is None) - deprecated_rules
changed_rules = set(rule.id for rule in rules if rule.contents.is_dirty) - deprecated_rules
# manage deprecated rules
newly_deprecated = deprecated_rules - already_deprecated
if not (new_rules or changed_rules or newly_deprecated):
return list(changed_rules), list(new_rules), list(newly_deprecated)
verbose_echo('Rule changes detected!')
for rule in rules:
if rule.contents.metadata.maturity == "production" or rule.id in newly_deprecated:
# assume that older stacks are always locked first
min_stack = _convert_lock_version(rule.contents.metadata.min_stack_version)
lock_info = rule.contents.lock_info(bump=not exclude_version_update)
current_rule_lock: dict = current_versions.setdefault(rule.id, {})
# scenarios to handle, assuming older stacks are always locked first:
# 1) no breaking changes ever made or the first time a rule is created
# 2) on the latest, after a breaking change has been locked
# 3) on the latest stack, locking in a breaking change
# 4) on an old stack, after a breaking change has been made
latest_locked_stack_version = _convert_lock_version(current_rule_lock.get("min_stack_version"))
if not current_rule_lock or min_stack == latest_locked_stack_version:
# 1) no breaking changes ever made or the first time a rule is created
# 2) on the latest, after a breaking change has been locked
current_rule_lock.update(lock_info)
# add the min_stack_version to the lock if it's explicitly set
if rule.contents.metadata.min_stack_version is not None:
current_rule_lock["min_stack_version"] = str(min_stack)
elif min_stack > latest_locked_stack_version:
# 3) on the latest stack, locking in a breaking change
previous_lock_info = {
"rule_name": current_rule_lock["rule_name"],
"sha256": current_rule_lock["sha256"],
"version": current_rule_lock["version"],
}
current_rule_lock.setdefault("previous", {})
# move the current locked info into the previous section
current_rule_lock["previous"][str(latest_locked_stack_version)] = previous_lock_info
# overwrite the "latest" part of the lock at the top level
current_rule_lock.update(lock_info, min_stack_version=str(min_stack))
elif min_stack < latest_locked_stack_version:
# 4) on an old stack, after a breaking change has been made
assert str(min_stack) in current_rule_lock.get("previous", {}), \
f"Expected {rule.id} @ v{min_stack} in the rule lock"
# TODO: Figure out whether we support locking old versions and if we want to
# "leave room" by skipping versions when breaking changes are made.
# We can still inspect the version lock manually after locks are made,
# since it's a good summary of everything that happens
current_rule_lock["previous"][str(min_stack)] = lock_info
continue
else:
raise RuntimeError("Unreachable code")
for rule in rules.deprecated:
if rule.id in newly_deprecated:
rule_deprecations[rule.id] = {
"rule_name": rule.name,
"stack_version": current_stack_version,
"deprecation_date": rule.contents.metadata['deprecation_date']
}
if save_changes or verbose:
click.echo(f' - {len(changed_rules)} changed rules')
click.echo(f' - {len(new_rules)} new rules')
click.echo(f' - {len(newly_deprecated)} newly deprecated rules')
if not save_changes:
verbose_echo('run `build-release --update-version-lock` to update version.lock.json and deprecated_rules.json')
return list(changed_rules), list(new_rules), list(newly_deprecated)
new_hash = dict_hash(current_versions)
if versions_hash != new_hash:
save_etc_dump(current_versions, ETC_VERSION_LOCK_FILE)
click.echo('Updated version.lock.json file')
# reset the cache
load_versions.clear()
if newly_deprecated:
save_etc_dump(rule_deprecations, ETC_DEPRECATED_RULES_FILE)
click.echo('Updated deprecated_rules.json file')
return changed_rules, list(new_rules), newly_deprecated
@cached
def load_versions():
"""Load the versions file."""
return load_etc_dump(ETC_VERSION_LOCK_FILE)
def save_versions(current_versions: dict):
save_etc_dump(current_versions, ETC_VERSION_LOCK_FILE)
print('Updated version.lock.json file')