1f015ebe85
* Ensure kql2eql conversion doesnt support `text` fields * Add unit test cases for`text` not supported in eql * test `field not recognized` in the rule_validator and output a verbose message. * use elasticsearch_type_family to lookup text mappings Co-authored-by: Justin Ibarra <brokensound77@users.noreply.github.com>
248 lines
9.4 KiB
Python
248 lines
9.4 KiB
Python
# Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
|
# or more contributor license agreements. Licensed under the Elastic License
|
|
# 2.0; you may not use this file except in compliance with the Elastic License
|
|
# 2.0.
|
|
|
|
"""Test stack versioned schemas."""
|
|
import copy
|
|
import unittest
|
|
import uuid
|
|
|
|
import eql
|
|
|
|
from detection_rules import utils
|
|
from detection_rules.packaging import load_current_package_version
|
|
from detection_rules.rule import TOMLRuleContents
|
|
from detection_rules.schemas import downgrade
|
|
from detection_rules.semver import Version
|
|
|
|
|
|
class TestSchemas(unittest.TestCase):
|
|
"""Test schemas and downgrade functions."""
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
cls.current_version = load_current_package_version()
|
|
|
|
# expected contents for a downgraded rule
|
|
cls.v78_kql = {
|
|
"description": "test description",
|
|
"index": ["filebeat-*"],
|
|
"language": "kuery",
|
|
"name": "test rule",
|
|
"query": "process.name:test.query",
|
|
"risk_score": 21,
|
|
"rule_id": str(uuid.uuid4()),
|
|
"severity": "low",
|
|
"type": "query",
|
|
"threat": [
|
|
{
|
|
"framework": "MITRE ATT&CK",
|
|
"tactic": {
|
|
"id": "TA0001",
|
|
"name": "Execution",
|
|
"reference": "https://attack.mitre.org/tactics/TA0001/"
|
|
},
|
|
"technique": [
|
|
{
|
|
"id": "T1059",
|
|
"name": "Command and Scripting Interpreter",
|
|
"reference": "https://attack.mitre.org/techniques/T1059/",
|
|
}
|
|
],
|
|
}
|
|
]
|
|
}
|
|
cls.v79_kql = dict(cls.v78_kql, author=["Elastic"], license="Elastic License v2")
|
|
cls.v711_kql = copy.deepcopy(cls.v79_kql)
|
|
# noinspection PyTypeChecker
|
|
cls.v711_kql["threat"][0]["technique"][0]["subtechnique"] = [{
|
|
"id": "T1059.001",
|
|
"name": "PowerShell",
|
|
"reference": "https://attack.mitre.org/techniques/T1059/001/"
|
|
}]
|
|
# noinspection PyTypeChecker
|
|
cls.v711_kql["threat"].append({
|
|
"framework": "MITRE ATT&CK",
|
|
"tactic": {
|
|
"id": "TA0008",
|
|
"name": "Lateral Movement",
|
|
"reference": "https://attack.mitre.org/tactics/TA0008/"
|
|
},
|
|
})
|
|
|
|
cls.v79_threshold_contents = {
|
|
"author": ["Elastic"],
|
|
"description": "test description",
|
|
"language": "kuery",
|
|
"license": "Elastic License v2",
|
|
"name": "test rule",
|
|
"query": "process.name:test.query",
|
|
"risk_score": 21,
|
|
"rule_id": str(uuid.uuid4()),
|
|
"severity": "low",
|
|
"threshold": {
|
|
"field": "destination.bytes",
|
|
"value": 75,
|
|
},
|
|
"type": "threshold",
|
|
}
|
|
cls.v712_threshold_rule = dict(copy.deepcopy(cls.v79_threshold_contents), threshold={
|
|
'field': ['destination.bytes', 'process.args'],
|
|
'value': 75,
|
|
'cardinality': [{
|
|
'field': 'user.name',
|
|
'value': 2
|
|
}]
|
|
})
|
|
|
|
def test_query_downgrade_7_x(self):
|
|
"""Downgrade a standard KQL rule."""
|
|
if Version(self.current_version) > (7,):
|
|
return
|
|
|
|
self.assertDictEqual(downgrade(self.v711_kql, "7.11"), self.v711_kql)
|
|
self.assertDictEqual(downgrade(self.v711_kql, "7.9"), self.v79_kql)
|
|
self.assertDictEqual(downgrade(self.v711_kql, "7.9.2"), self.v79_kql)
|
|
self.assertDictEqual(downgrade(self.v711_kql, "7.8.1"), self.v78_kql)
|
|
self.assertDictEqual(downgrade(self.v79_kql, "7.8"), self.v78_kql)
|
|
self.assertDictEqual(downgrade(self.v79_kql, "7.8"), self.v78_kql)
|
|
|
|
with self.assertRaises(ValueError):
|
|
downgrade(self.v711_kql, "7.7")
|
|
|
|
with self.assertRaises(ValueError):
|
|
downgrade(self.v79_kql, "7.7")
|
|
|
|
with self.assertRaises(ValueError):
|
|
downgrade(self.v78_kql, "7.7", current_version="7.8")
|
|
|
|
def test_versioned_downgrade_7_x(self):
|
|
"""Downgrade a KQL rule with version information"""
|
|
if Version(self.current_version) > (7,):
|
|
return
|
|
|
|
api_contents = self.v79_kql
|
|
self.assertDictEqual(downgrade(api_contents, "7.9"), api_contents)
|
|
self.assertDictEqual(downgrade(api_contents, "7.9.2"), api_contents)
|
|
|
|
api_contents78 = api_contents.copy()
|
|
api_contents78.pop("author")
|
|
api_contents78.pop("license")
|
|
|
|
self.assertDictEqual(downgrade(api_contents, "7.8"), api_contents78)
|
|
|
|
with self.assertRaises(ValueError):
|
|
downgrade(api_contents, "7.7")
|
|
|
|
def test_threshold_downgrade_7_x(self):
|
|
"""Downgrade a threshold rule that was first introduced in 7.9."""
|
|
if Version(self.current_version) > (7,):
|
|
return
|
|
|
|
api_contents = self.v712_threshold_rule
|
|
self.assertDictEqual(downgrade(api_contents, '7.13'), api_contents)
|
|
self.assertDictEqual(downgrade(api_contents, '7.13.1'), api_contents)
|
|
|
|
exc_msg = 'Cannot downgrade a threshold rule that has multiple threshold fields defined'
|
|
with self.assertRaisesRegex(ValueError, exc_msg):
|
|
downgrade(api_contents, '7.9')
|
|
|
|
v712_threshold_contents_single_field = copy.deepcopy(api_contents)
|
|
v712_threshold_contents_single_field['threshold']['field'].pop()
|
|
|
|
with self.assertRaisesRegex(ValueError, "Cannot downgrade a threshold rule that has a defined cardinality"):
|
|
downgrade(v712_threshold_contents_single_field, "7.9")
|
|
|
|
v712_no_cardinality = copy.deepcopy(v712_threshold_contents_single_field)
|
|
v712_no_cardinality['threshold'].pop('cardinality')
|
|
self.assertEqual(downgrade(v712_no_cardinality, "7.9"), self.v79_threshold_contents)
|
|
|
|
with self.assertRaises(ValueError):
|
|
downgrade(v712_no_cardinality, "7.7")
|
|
|
|
with self.assertRaisesRegex(ValueError, "Unsupported rule type"):
|
|
downgrade(v712_no_cardinality, "7.8")
|
|
|
|
def test_query_downgrade_8_x(self):
|
|
"""Downgrade a standard KQL rule."""
|
|
if Version(self.current_version) > (8,):
|
|
return
|
|
|
|
def test_versioned_downgrade_8_x(self):
|
|
"""Downgrade a KQL rule with version information"""
|
|
if Version(self.current_version) > (8,):
|
|
return
|
|
|
|
def test_threshold_downgrade_8_x(self):
|
|
"""Downgrade a threshold rule that was first introduced in 7.9."""
|
|
if Version(self.current_version) > (8,):
|
|
return
|
|
|
|
def test_eql_validation(self):
|
|
base_fields = {
|
|
"author": ["Elastic"],
|
|
"description": "test description",
|
|
"index": ["filebeat-*"],
|
|
"language": "eql",
|
|
"license": "Elastic License v2",
|
|
"name": "test rule",
|
|
"risk_score": 21,
|
|
"rule_id": str(uuid.uuid4()),
|
|
"severity": "low",
|
|
"type": "eql"
|
|
}
|
|
|
|
def build_rule(query):
|
|
metadata = {
|
|
"creation_date": "1970/01/01",
|
|
"updated_date": "1970/01/01",
|
|
"min_stack_version": load_current_package_version()
|
|
}
|
|
data = base_fields.copy()
|
|
data["query"] = query
|
|
obj = {"metadata": metadata, "rule": data}
|
|
return TOMLRuleContents.from_dict(obj)
|
|
|
|
build_rule("""
|
|
process where process.name == "cmd.exe"
|
|
""")
|
|
|
|
example_text_fields = ['client.as.organization.name.text', 'client.user.full_name.text',
|
|
'client.user.name.text', 'destination.as.organization.name.text',
|
|
'destination.user.full_name.text', 'destination.user.name.text',
|
|
'error.message', 'error.stack_trace.text', 'file.path.text',
|
|
'file.target_path.text', 'host.os.full.text', 'host.os.name.text',
|
|
'host.user.full_name.text', 'host.user.name.text']
|
|
for text_field in example_text_fields:
|
|
with self.assertRaises(eql.parser.EqlSchemaError):
|
|
build_rule(f"""
|
|
any where {text_field} == "some string field"
|
|
""")
|
|
|
|
with self.assertRaises(eql.EqlSyntaxError):
|
|
build_rule("""
|
|
process where process.name == this!is$not#v@lid
|
|
""")
|
|
|
|
with self.assertRaises(eql.EqlSemanticError):
|
|
build_rule("""
|
|
process where process.invalid_field == "hello world"
|
|
""")
|
|
|
|
with self.assertRaises(eql.EqlTypeMismatchError):
|
|
build_rule("""
|
|
process where process.pid == "some string field"
|
|
""")
|
|
|
|
|
|
class TestVersions(unittest.TestCase):
|
|
"""Test that schema versioning aligns."""
|
|
|
|
def test_stack_schema_map(self):
|
|
"""Test to ensure that an entry exists in the stack-schema-map for the current package version."""
|
|
package_version = Version(load_current_package_version())
|
|
stack_map = utils.load_etc_dump('stack-schema-map.yaml')
|
|
err_msg = f'There is no entry defined for the current package ({package_version}) in the stack-schema-map'
|
|
self.assertIn(package_version, [Version(v)[:2] for v in stack_map], err_msg)
|