Terrance DeJesus
fb2b4529c5
* removed custom semver and replaced with pypi * updated beats.py version references * updated bump-versions CLI command to use semver and change logic * updated schemas __init__, test_version_lock and unstage incompatible rules CLI * updated test_stack_schema_map in TestVersions unittest * updated test_all_rules unit testing Version() references * updated stack_compat.py for get_restricted_field references) * updated version_lock.py Version() references * updated docs.py Version() reference for parse_registry * updated devtools.py Version() reference for trim-version-lock * updated mixins.py Version() reference in validate_field_compatibility * adjusted schemas.__init__ Version() reference in get_stack_schemas * adjusted ecs.py Version() references * adjusted integrations.py Version() references * adjusted rule.py Version() references * sorted imports * replaced custom semver with pypi semver in unit test files * addressed unit test and flake errors * changed semver strings casted to version_lock.py * fixed sorting in integrations.py * updated bump-pkgs-versions CLI command * adjusted semantic version in unstage-incompatible-rules command * adjusted semver import to VersionInfo * added semver 3 and adjusted import names * added option_minor_and_patch parameter where version is major.minor * updated bump-pkg-versions to always save to packages.yml * removed leftover split call & updated find latest compatible version command * updated integrations.py, version_lock.py and schemas.__init__.py * changed fstring reference in downgrade function * reverted formatting changes for detection_rules __init__.py * added newline to detection_rules __init__.py * adjusted finding latest_release for attack package logic * adjusted unstage-incompatible-rules command logic comparing versions * removing changes from misc.py related to auto-formatting * adding newline to misc.py * fixed bug in downgrade function calling decorators * added semantic version validation on migrate decorator function * added expected type returned from find_latest_integration_version in integrations.py * add comment about stripped versions for version lock file Co-authored-by: Mika Ayenson <Mikaayenson@users.noreply.github.com> --------- Co-authored-by: Mika Ayenson <Mikaayenson@users.noreply.github.com>
37 lines
1.7 KiB
Python
37 lines
1.7 KiB
Python
# Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
|
# or more contributor license agreements. Licensed under the Elastic License
|
|
# 2.0; you may not use this file except in compliance with the Elastic License
|
|
# 2.0.
|
|
|
|
"""Test version locking of rules."""
|
|
|
|
import unittest
|
|
|
|
from semver import Version
|
|
|
|
from detection_rules.schemas import get_min_supported_stack_version
|
|
from detection_rules.version_lock import default_version_lock
|
|
|
|
|
|
class TestVersionLock(unittest.TestCase):
|
|
"""Test version locking."""
|
|
|
|
def test_previous_entries_gte_current_min_stack(self):
|
|
"""Test that all previous entries for all locks in the version lock are >= the current min_stack."""
|
|
errors = {}
|
|
min_version = get_min_supported_stack_version()
|
|
for rule_id, lock in default_version_lock.version_lock.to_dict().items():
|
|
if 'previous' in lock:
|
|
prev_vers = [Version.parse(v, optional_minor_and_patch=True) for v in list(lock['previous'])]
|
|
outdated = [str(v).lstrip(".0") for v in prev_vers if v < min_version]
|
|
if outdated:
|
|
errors[rule_id] = outdated
|
|
|
|
# This should only ever happen when bumping the backport matrix support up, which is based on the
|
|
# stack-schema-map
|
|
if errors:
|
|
err_str = '\n'.join(f'{k}: {", ".join(v)}' for k, v in errors.items())
|
|
self.fail(f'The following version.lock entries have previous locked versions which are lower than the '
|
|
f'currently supported min_stack ({min_version}). To address this, run the '
|
|
f'`dev trim-version-lock {min_version}` command.\n\n{err_str}')
|