From 95486ecfdf9cb07097aa9a4a9a6513cc10febdd8 Mon Sep 17 00:00:00 2001 From: Justin Ibarra Date: Thu, 5 Aug 2021 11:15:07 -0800 Subject: [PATCH] [Bug] Flatten method improperly added subtechniques (#1404) --- detection_rules/rule.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/detection_rules/rule.py b/detection_rules/rule.py index 6e2bee580..4380702e0 100644 --- a/detection_rules/rule.py +++ b/detection_rules/rule.py @@ -103,8 +103,8 @@ class ThreatMapping(MarshmallowDataclassMixin): technique_ids.add(technique.id) for subtechnique in (technique.subtechnique or []): - sub_technique_ids.update(subtechnique.id) - sub_technique_names.update(subtechnique.name) + sub_technique_ids.add(subtechnique.id) + sub_technique_names.add(subtechnique.name) return FlatThreatMapping( tactic_names=sorted(tactic_names),