From 7da343e89f748859dd8d879caf81e3a4f7dbebcd Mon Sep 17 00:00:00 2001 From: Ross Wolf <31489089+rw-access@users.noreply.github.com> Date: Wed, 28 Oct 2020 10:16:36 -0600 Subject: [PATCH] Fix kibana upload command (#425) --- detection_rules/kbwrap.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/detection_rules/kbwrap.py b/detection_rules/kbwrap.py index 2534d112d..3083793d3 100644 --- a/detection_rules/kbwrap.py +++ b/detection_rules/kbwrap.py @@ -29,7 +29,7 @@ def kibana_group(ctx: click.Context, **kibana_kwargs): click.echo(format_command_options(ctx)) else: - if not kibana_kwargs['cloud_id'] or kibana_kwargs['kibana_url']: + if not (kibana_kwargs['cloud_id'] or kibana_kwargs['kibana_url']): client_error("Missing required --cloud-id or --kibana-url") # don't prompt for these until there's a cloud id or Kibana URL @@ -70,5 +70,6 @@ def upload_rule(ctx, toml_files): rule = RuleResource(payload) api_payloads.append(rule) - rules = RuleResource.bulk_create(api_payloads) - click.echo(f"Successfully uploaded {len(rules)} rules") + with kibana: + rules = RuleResource.bulk_create(api_payloads) + click.echo(f"Successfully uploaded {len(rules)} rules")