From 32c0e9fff5bf1a0eade8b6d60c9cfb714d3cbd18 Mon Sep 17 00:00:00 2001 From: Ross Wolf <31489089+rw-access@users.noreply.github.com> Date: Tue, 27 Jul 2021 13:48:28 -0600 Subject: [PATCH] Disable missing rule check for the version lock (#1384) (cherry picked from commit c31a34459382ed1cc5bb2e935473d0c7f4791df1) --- tests/test_all_rules.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tests/test_all_rules.py b/tests/test_all_rules.py index b1f9744ea..75888e7a3 100644 --- a/tests/test_all_rules.py +++ b/tests/test_all_rules.py @@ -402,12 +402,14 @@ class TestRuleMetadata(BaseRuleTest): err_msg = f'{self.rule_str(rule)} deprecation_date and updated_date should match' self.assertEqual(meta.deprecation_date, meta.updated_date, err_msg) - missing_rules = sorted(set(versions).difference(set(self.rule_lookup))) - missing_rule_strings = '\n '.join(f'{r} - {versions[r]["rule_name"]}' for r in missing_rules) - err_msg = f'Deprecated rules should not be removed, but moved to the rules/_deprecated folder instead. ' \ - f'The following rules have been version locked and are missing. ' \ - f'Re-add to the deprecated folder and update maturity to "deprecated": \n {missing_rule_strings}' - self.assertEqual([], missing_rules, err_msg) + # skip this so the lock file can be shared across branches + # + # missing_rules = sorted(set(versions).difference(set(self.rule_lookup))) + # missing_rule_strings = '\n '.join(f'{r} - {versions[r]["rule_name"]}' for r in missing_rules) + # err_msg = f'Deprecated rules should not be removed, but moved to the rules/_deprecated folder instead. ' \ + # f'The following rules have been version locked and are missing. ' \ + # f'Re-add to the deprecated folder and update maturity to "deprecated": \n {missing_rule_strings}' + # self.assertEqual([], missing_rules, err_msg) for rule_id, entry in deprecations.items(): rule_str = f'{rule_id} - {entry["rule_name"]} ->'