From 28f67e3acee81f57798a4827c240addcb3f8604a Mon Sep 17 00:00:00 2001 From: shashank-elastic <91139415+shashank-elastic@users.noreply.github.com> Date: Fri, 28 Jun 2024 23:18:09 +0530 Subject: [PATCH] Generate Better Index Keys (#3826) * Generate Better Index Keys * More Robust index mapping * Remove unused import * Remove unused import --------- Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> Co-authored-by: Mika Ayenson (cherry picked from commit 949ceccc0f54ec941c609d99133a750203b3425d) --- detection_rules/packaging.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/detection_rules/packaging.py b/detection_rules/packaging.py index 5dbfd3b89..36044c657 100644 --- a/detection_rules/packaging.py +++ b/detection_rules/packaging.py @@ -246,7 +246,6 @@ class Package(object): def generate_summary_and_changelog(self, changed_rule_ids, new_rule_ids, removed_rules): """Generate stats on package.""" - from string import ascii_lowercase, ascii_uppercase summary = { 'changed': defaultdict(list), @@ -261,7 +260,7 @@ class Package(object): 'unchanged': defaultdict(list) } - # build an index map first + # Build an index map first longest_name = 0 indexes = set() for rule in self.rules: @@ -270,8 +269,7 @@ class Package(object): if index_list: indexes.update(index_list) - letters = ascii_uppercase + ascii_lowercase - index_map = {index: letters[i] for i, index in enumerate(sorted(indexes))} + index_map = {index: str(i) for i, index in enumerate(sorted(indexes))} def get_summary_rule_info(r: TOMLRule): r = r.contents