RageLtMan
42d1fae2e6
The -S flag for console commands, backed by search functionality in Rex' tables, originally pushed upstream in #1604 (iirc), lacks coverage for a number of commands which benefit a good deal from inline filtering of the potentially large number of results. Push more -S flags and surrounding table functionality upstream to provide coverage for the console commands included in framework. Include a fix for deleting hosts when DB references are a problem. Include a fix for the upstream route command wherein scope must be defined for the routing target by assuming a /32 without explicit definition. Note: With this in place, console behavior when filtering results is roughly analagous to the R7 filtering in web UI, which should help those of us trying to use both maintain corresponding workflows. Testing: Used in-house for years, though changes to the diff from upstream and our fork (expunging some internal code) are untested, so would appreciate eyes and hands on.
99 lines
2.4 KiB
Ruby
99 lines
2.4 KiB
Ruby
require 'spec_helper'
|
|
|
|
require 'msf/ui'
|
|
require 'msf/ui/console/module_command_dispatcher'
|
|
require 'msf/ui/console/command_dispatcher/core'
|
|
|
|
RSpec.describe Msf::Ui::Console::CommandDispatcher::Modules do
|
|
include_context 'Msf::DBManager'
|
|
include_context 'Msf::UIDriver'
|
|
|
|
subject(:core) do
|
|
described_class.new(driver)
|
|
end
|
|
|
|
context '#search_modules_sql' do
|
|
def search_modules_sql
|
|
core.search_modules_sql(match)
|
|
end
|
|
|
|
let(:match) do
|
|
''
|
|
end
|
|
|
|
it 'should generate Matching Modules table' do
|
|
expect(core).to receive(:generate_module_table).with('Matching Modules', nil).and_call_original
|
|
|
|
search_modules_sql
|
|
end
|
|
|
|
it 'should call Msf::DBManager#search_modules' do
|
|
expect(db_manager).to receive(:search_modules).with(match).and_return([])
|
|
|
|
search_modules_sql
|
|
end
|
|
|
|
context 'with matching Mdm::Module::Details' do
|
|
let(:match) do
|
|
module_detail.fullname
|
|
end
|
|
|
|
let!(:module_detail) do
|
|
FactoryGirl.create(:mdm_module_detail)
|
|
end
|
|
|
|
context 'printed table' do
|
|
def cell(table, row, column)
|
|
row_line_number = 6 + row
|
|
line_number = 0
|
|
|
|
cell = nil
|
|
|
|
table.each_line do |line|
|
|
if line_number == row_line_number
|
|
# strip prefix and postfix
|
|
padded_cells = line[3...-1]
|
|
cells = padded_cells.split(/\s{2,}/)
|
|
|
|
cell = cells[column]
|
|
break
|
|
end
|
|
|
|
line_number += 1
|
|
end
|
|
|
|
cell
|
|
end
|
|
|
|
let(:printed_table) do
|
|
table = ''
|
|
|
|
expect(core).to receive(:print_line) do |string|
|
|
table = string
|
|
end
|
|
|
|
search_modules_sql
|
|
|
|
table
|
|
end
|
|
|
|
it 'should have fullname in first column' do
|
|
expect(cell(printed_table, 0, 0)).to include(module_detail.fullname)
|
|
end
|
|
|
|
it 'should have disclosure date in second column' do
|
|
expect(cell(printed_table, 0, 1)).to include(module_detail.disclosure_date.strftime("%Y-%m-%d"))
|
|
end
|
|
|
|
it 'should have rank name in third column' do
|
|
expect(cell(printed_table, 0, 2)).to include(Msf::RankingName[module_detail.rank])
|
|
end
|
|
|
|
it 'should have name in fourth column' do
|
|
expect(cell(printed_table, 0, 3)).to include(module_detail.name)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|