Luke Imhoff
93469604a7
I missed a spot where I referenced the nested_paths as nested_pathnams after I renamed the variable. Now, Msf::ModuleManager#add_module_paths has rspec tests. Rspec can be invoked with `rake` as the default task or `rake spec` explicitly. I changed RuntimeError to ArgumentError since that error was more specific to having a bad argument error. I adding missing dependencies to the Gemfile and a require to msf/core/db_manager.rb where it errored out trying to access Msf::Config when I just did require 'msf/core' in the spec.
110 lines
2.6 KiB
Ruby
110 lines
2.6 KiB
Ruby
require 'spec_helper'
|
|
|
|
#
|
|
# Core
|
|
#
|
|
|
|
# Temporary files
|
|
require 'tempfile'
|
|
# add mktmpdir to Dir
|
|
require 'tmpdir'
|
|
|
|
#
|
|
# Project
|
|
#
|
|
|
|
require 'msf/core'
|
|
|
|
describe Msf::ModuleManager do
|
|
let(:archive_basename) do
|
|
[basename_prefix, archive_extension]
|
|
end
|
|
|
|
let(:archive_extension) do
|
|
'.fastlib'
|
|
end
|
|
|
|
let(:basename_prefix) do
|
|
'rspec'
|
|
end
|
|
|
|
let(:framework) do
|
|
Msf::Framework.new
|
|
end
|
|
|
|
subject do
|
|
described_class.new(framework)
|
|
end
|
|
|
|
context '#add_module_path' do
|
|
it 'should strip trailing File::SEPARATOR from the path' do
|
|
Dir.mktmpdir do |path|
|
|
path_with_trailing_separator = path + File::SEPARATOR
|
|
subject.add_module_path(path_with_trailing_separator)
|
|
|
|
subject.send(:module_paths).should_not include(path_with_trailing_separator)
|
|
subject.send(:module_paths).should include(path)
|
|
end
|
|
end
|
|
|
|
context 'with Fastlib archive' do
|
|
it 'should raise an ArgumentError unless the File exists' do
|
|
file = Tempfile.new(archive_basename)
|
|
# unlink will clear path, so copy it to a variable
|
|
path = file.path
|
|
file.unlink
|
|
|
|
File.exist?(path).should be_false
|
|
|
|
expect {
|
|
subject.add_module_path(path)
|
|
}.to raise_error(ArgumentError, "The path supplied does not exist")
|
|
end
|
|
|
|
it 'should add the path to #module_paths if the File exists' do
|
|
Tempfile.open(archive_basename) do |temporary_file|
|
|
path = temporary_file.path
|
|
|
|
File.exist?(path).should be_true
|
|
|
|
subject.add_module_path(path)
|
|
|
|
subject.send(:module_paths).should include(path)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with directory' do
|
|
it 'should add path to #module_paths' do
|
|
Dir.mktmpdir do |path|
|
|
subject.add_module_path(path)
|
|
|
|
subject.send(:module_paths).should include(path)
|
|
end
|
|
end
|
|
|
|
context 'containing Fastlib archives' do
|
|
it 'should add each Fastlib archive to #module_paths' do
|
|
Dir.mktmpdir do |directory|
|
|
Tempfile.open(archive_basename, directory) do |file|
|
|
subject.add_module_path(directory)
|
|
|
|
subject.send(:module_paths).should include(directory)
|
|
subject.send(:module_paths).should include(file.path)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with other file' do
|
|
it 'should raise ArgumentError' do
|
|
Tempfile.open(basename_prefix) do |file|
|
|
expect {
|
|
subject.add_module_path(file.path)
|
|
}.to raise_error(ArgumentError, 'The path supplied is not a valid directory.')
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end |