f2a8d68a1f
Net::SSH::KeyFactory permits loading keys using a passphrase. The Framework SSH modules were implemented back when we had a fork of net-ssh in our tree, and can now use functionality provided by the upstream gem. Update the ssh key login scanner to add a KEY_PASS datastore OptString which is then passed to the KeyCollection class and used in the updated :read_key method which now calls the KeyFactory to read data and give us the appropriate String representation of the key in the KeyCollection's cache. A bit of cleanup performed as well, removing legacy code paths no longer hit by the module. Shamelessly added self to authors, fair amount of blood and sweat in the SSH subsystem over the years, hope nobody objects. Testing: None yet