Commit Graph

129 Commits

Author SHA1 Message Date
gwillcox-r7 b524e5676f Apply RuboCop fixes to tools/dev/check_external_scripts.rb 2020-08-05 11:48:55 -05:00
gwillcox-r7 38e116d5be Add in fix to prevent us from having to clone the sqlmap project every time that we want to decloak another sqlmap file 2020-08-05 11:40:49 -05:00
gwillcox-r7 5460e35e84 Add in additional checks to the decloak() function to check if python or python3 is installed and to try both options, to try ensure the git repo is cloned correctly, and to make sure that operations complete successfully before moving onto the next one. Also added in fixes from review notes for minor issues. 2020-08-05 11:10:39 -05:00
h00die 41058775b3 add sharphound exe, rubocop, and final update run 2020-08-04 09:06:45 -04:00
h00die 9663d3378f add sqlmap decloak 2020-08-04 08:48:30 -04:00
h00die 42b2f306d1 adding udf and john to external scripts 2020-08-04 08:46:47 -04:00
Spencer McIntyre 73cace16a3 Add checks to msftidy_docs and update the template for them 2020-07-23 20:37:39 -04:00
Josh 68c9cfb593 ZDI Public numbers should be limited to 4 digits
to avoid false negatives per the discussion at #13311
2020-04-28 18:48:10 -05:00
gwillcox-r7 5f997ef814 Land #13340, Fix broken PKS and update link 2020-04-27 15:44:52 -05:00
Tod Beardsley ec10216f6b Fix broken link to broken PKS for key verification 2020-04-26 11:12:06 -05:00
William Vu 21653f09c2 Fix bad regex in ZDI reference check for msftidy 2020-04-23 00:47:52 -05:00
Josh 2c80859564 ZDI Public Numbers can be 4 digits, ZDI-19-1045
Also, technically, ZDI Public Numbers will always have a min of 3 digits.
The number is essentially `"num_as_string".ljust(3, '0')`, so this should be {3,4}
or {3,5} if they ever get that high ;) I could find no ZDI- references or similar that
only had 2 digits in the last number part

references:
https://www.zerodayinitiative.com/advisories/ZDI-19-1045/
https://www.zerodayinitiative.com/advisories/ZDI-05-001/
2020-04-22 14:46:21 -05:00
tperry-r7 62dd03c348 Land #13188 new msftidy_docs
Land #13188 new msftidy_docs. Change Options from bold to h3 instead.
2020-04-06 10:08:06 -05:00
Brent Cook 8451c1345b Land #10579, add sharphound post module, upstream updating tool 2020-04-03 09:10:40 -05:00
Brent Cook b18a2fd463 Support inline transforms on tools, make some code snazzier 2020-04-02 21:32:10 -05:00
Brent Cook f2d3cdca4b make check_external_scripts executable 2020-04-02 21:11:09 -05:00
h00die f3ebd26e73 add rhosts 2020-04-02 19:19:10 -04:00
h00die f9ecbc2179 new tidy_docs checks 2020-04-02 19:10:39 -04:00
h00die f5c4f593f5 check for more default instructional text 2020-03-24 09:51:21 -04:00
h00die e7da6e77a5 remove and check for instruction text 2020-03-24 09:15:04 -04:00
Jeffrey Martin cda9fd2a08 lock license_finder at 5.11.1 due to bundler 2.x 2020-02-28 08:57:19 -06:00
h00die c0e34581f2 add external script checker 2020-02-08 15:59:32 -05:00
William Vu 793d5c3342 chmod +x tools/dev/msftidy_docs.rb
a099481f66 failed to do so.
2020-02-06 19:21:07 -06:00
h00die bd48588fd5 catch false positive spaces at eol from code indent 2020-01-28 14:28:18 -05:00
h00die 0c13102432 long lines ok in code blocks 2020-01-22 21:08:32 -05:00
h00die a099481f66 fix logic bug and chmod +x 2020-01-22 19:24:01 -05:00
h00die 322b3f8a8b msftidy_docs first add 2020-01-22 17:39:48 -05:00
Brendan Coles ddf9cf71ab Add check_executable check to msftidy 2019-11-30 07:25:27 +00:00
Brent Cook 0308f80c0e fix Failure scoping (needed for libraries) 2019-04-08 09:57:22 -05:00
William Vu c1758037b9 Include only common module types in Authors check 2019-03-29 10:44:22 -05:00
Pearce Barry 20f868c15c Complain loudly if module has no 'Author' metadata. 2019-03-26 13:27:57 -05:00
Brent Cook 8cc3070cc8 don't require whitespace 2019-02-25 11:24:30 -06:00
Jacob Robles c09c15649f SideEffects Stability Reliability check 2019-02-21 12:38:26 -06:00
Brent Cook 46d7ab9795 don't refer to non-existent idx 2019-02-07 00:42:28 -06:00
Brendan Coles d38e12c124 Add URL scheme and Base64.encode64 checks to msftdiy 2019-02-04 21:16:01 +00:00
Matthew Kienow 5e28bccda9 Move msfdb_ws since it is deprecated by msfdb 2019-01-09 23:40:02 -05:00
William Vu 2b231d33e5 Add comment clarifying why we need the day for ISO 2018-11-16 13:25:01 -06:00
William Vu 2302acaab7 Accept ISO 8601 DisclosureDate with compatibility
Zalgo.
2018-11-16 12:03:01 -06:00
William Vu f25d7dbaa8 Revert Date.parse check for DisclosureDate
An approximation of https://en.wikipedia.org/wiki/Robustness_principle.
2018-11-16 11:48:44 -06:00
William Vu d65ba41e31 Use non-greedy regex against DisclosureDate
Zalgo. He comes.

wvu@kharak:~/metasploit-framework:bug/msftidy$ tools/dev/msftidy.rb modules/exploits/unix/webapp/jquery_file_upload.rb
"Oct 9 2018', # Larry"
wvu@kharak:~/metasploit-framework:bug/msftidy$
2018-11-16 11:40:12 -06:00
William Vu 3dd47b34b0 Rework DisclosureDate check to match core code
Framework core uses Date.parse, so many date formats are valid.

There is no reason we shouldn't be using ISO 8601 dates.
2018-11-16 11:05:47 -06:00
William Vu a30403dbfe Improve DisclosureDate regex 2018-11-16 03:46:51 -06:00
William Vu 02bb2d45d3 Make day in DisclosureDate optional for msftidy
Defaults to the first day of the month.
2018-11-16 03:00:39 -06:00
William Vu 0b8926715e Reactively check for invalid module names 2018-10-10 14:33:59 -05:00
Wei Chen b012fa1275 Update msftidy 2018-10-06 15:59:05 -05:00
William Vu 2186322134 Stop being an idiot about the regex and rewrite it
There was no reason to shoehorn in zero-length assertions.
2018-10-05 13:50:19 -05:00
William Vu 05ac3875bc Improve check_snake_case_filename check in msftidy
We also remove the separator, since the file is basenamed.
2018-10-05 11:55:17 -05:00
Erin Bleiweiss e753eddb6b Ignore 'No CVE' warning if NOCVE reason was provided in notes 2018-08-31 16:53:44 -05:00
Christian Mehlmauer 69d321000e check double quotes 2018-08-29 06:49:37 +02:00
Christian Mehlmauer 31d4d4f5ff expand check 2018-08-29 06:42:01 +02:00