From e31a144f4db28553962cbaed05f32d6800a2390c Mon Sep 17 00:00:00 2001
From: Meatballs <eat_meatballs@hotmail.co.uk>
Date: Sat, 22 Feb 2014 20:34:56 +0000
Subject: [PATCH] Use better system call

---
 lib/msf/base/sessions/vncinject.rb | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/lib/msf/base/sessions/vncinject.rb b/lib/msf/base/sessions/vncinject.rb
index 5c1f1ef69a..eaa7decf8f 100644
--- a/lib/msf/base/sessions/vncinject.rb
+++ b/lib/msf/base/sessions/vncinject.rb
@@ -158,14 +158,12 @@ class VncInject
       Rex::FileUtils::find_full_path('vncviewer.exe')
 
     if (vnc)
-      if viewonly
-        vo = "-viewonly "
-      else
-        vo = ""
-      end
+      args = []
+      args.push '-viewonly' if viewonly
+      args.push "#{vlhost}::#{vlport}"
 
       self.view = framework.threads.spawn("VncViewerWrapper", false) {
-        system("vncviewer #{vo}#{vlhost}::#{vlport}")
+        system(vnc, *args)
       }
 
       return true