From 799cb4429728fa14be483022cae16bc25de23a1b Mon Sep 17 00:00:00 2001 From: wchen-r7 Date: Tue, 22 May 2012 08:48:13 -0700 Subject: [PATCH] Updated Common Metasploit Module Bad Coding Practice (markdown) --- Common-Metasploit-Module-Bad-Coding-Practice.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Common-Metasploit-Module-Bad-Coding-Practice.md b/Common-Metasploit-Module-Bad-Coding-Practice.md index 0ed2f60e5c..0414e29325 100644 --- a/Common-Metasploit-Module-Bad-Coding-Practice.md +++ b/Common-Metasploit-Module-Bad-Coding-Practice.md @@ -149,8 +149,9 @@ Note: Some of these examples use puts() for demo purposes, but you should always **10. Using global variables** ```ruby # $msg is a global variable that can be accessed anywhere within the program. - # This can induce bugs to other modules, libs, or mixins that are painful to solve. + # This can induce bugs to other modules or mixins that are hard to debug. # Use @instance variables instead. + # This is also mentioned in your HACKING file :-) class Opinion def initialize @@ -168,4 +169,5 @@ Note: Some of these examples use puts() for demo purposes, but you should always Opinion.new Metasploit3.new + ``` \ No newline at end of file